Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/dbt): support use_compiled_code and test_warnings_are_errors #8956

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat(ingest/dbt): support use_compiled_code and test_warnings_are_errors #8956

merged 2 commits into from
Oct 5, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 4, 2023 •
edited
Loading

There were both long-requested items, so finally adding them. test_warnings_are_errors having a default of true is technically a breaking change.

It might be easier to review this by commit.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 4, 2023
@hsheth2 hsheth2 requested a review from asikowitz October 5, 2023 02:08
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Oct 5, 2023

Another glossary/glossary_navigation.js flake in smoke test, merging through it

@hsheth2 hsheth2 merged commit 3cede10 into datahub-project:master Oct 5, 2023
55 of 56 checks passed
@hsheth2 hsheth2 deleted the dbt-tweaks branch October 5, 2023 17:29
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsheth2 @asikowitz @maggiehays