feat(ingest/tableau): Allow parsing of database name from fullName #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
commented
Oct 10, 2023
| @@ -605,43 +711,16 @@ def get_overridden_info( | |||
| ): | |||
| upstream_db = lineage_overrides.database_override_map[upstream_db] | |||
|
|
|||
| platform_instance = get_platform_instance(original_platform, platform_instance_map) | |||
There was a problem hiding this comment.
Removed this method in favor of this one line statement
|
|
||
| return full_name.replace("[", "").replace("]", "").split(".") | ||
|
|
||
| def make_dataset_urn( |
There was a problem hiding this comment.
Basically copied from make_table_urn
| connection_type: str | ||
|
|
||
| @classmethod | ||
| def create( |
There was a problem hiding this comment.
Meant to replicate logic in get_upstream_tables. Pulls values out of table dict, parses schema from full_name and default_schema_map (and now parses database too), and does this schema in table check for redshift
| @@ -537,12 +542,12 @@ def get_fully_qualified_table_name( | |||
| platform: str, | |||
| upstream_db: str, | |||
| schema: str, | |||
| full_name: str, | |||
| table_name: str, | |||
There was a problem hiding this comment.
This was never passed full_name...:
table_urn = make_table_urn(
self.config.env,
upstream_db,
table.get(tableau_constant.CONNECTION_TYPE) or "",
schema,
table_name,
self.config.platform_instance_map,
self.config.lineage_overrides,
)
```
5th argument is clearly `table_name`, not `full_name`
asikowitz
commented
Oct 10, 2023
| @@ -2462,35 +2437,6 @@ def emit_embedded_datasources(self) -> Iterable[MetadataWorkUnit]: | |||
| is_embedded_ds=True, | |||
| ) | |||
|
|
|||
| @lru_cache(maxsize=None) | |||
There was a problem hiding this comment.
I lose the lru_cache capabilities, but I don't think that matters... these are such simple and quick operations
hsheth2
approved these changes
Oct 10, 2023
|
Merging before smoke tests to create release |
asikowitz
added a commit
to asikowitz/datahub
that referenced
this pull request
Oct 10, 2023
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recognize this is a decent refactor, but I didn't want to keep contributing to this scattered urn generation process. This is meant to replicate existing behavior, aside from adding the ability to parse
[database].[schema].[table]fromfullName. Also now parses table name from[schema].[table], when it used to only parse the schema nameChecklist