feat(ingest/unity-catalog): Support external S3 lineage #9025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
approved these changes
Oct 17, 2023
| s3_name = strip_s3_prefix(s3_uri) | ||
|
|
||
| if s3_name.endswith("/"): | ||
| s3_name = s3_name[:-1] | ||
|
|
||
| name, extension = os.path.splitext(s3_name) | ||
|
|
||
| if extension != "": | ||
| if remove_extension and extension != "": | ||
| extension = extension[1:] # remove the dot | ||
| return f"urn:li:dataset:(urn:li:dataPlatform:s3,{name}_{extension},{env})" |
There was a problem hiding this comment.
Maybe instead of underscore it would be better to just URL encode the dot
There was a problem hiding this comment.
In general maybe we should url encode the urn parts
treff7es
reviewed
Oct 17, 2023
| s3_name = strip_s3_prefix(s3_uri) | ||
|
|
||
| if s3_name.endswith("/"): | ||
| s3_name = s3_name[:-1] | ||
|
|
||
| name, extension = os.path.splitext(s3_name) | ||
|
|
||
| if extension != "": | ||
| if remove_extension and extension != "": |
There was a problem hiding this comment.
Suggested change
| if remove_extension and extension != "": | |
| if remove_extension and extension: |
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@treff7es can you explain why
make_s3_urnremoves the period in the extension. I had to undo that for external lineage to match urns, as the S3 source creates urns with periods in them. Do you know if we can make this consistent?Checklist