Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata-ingestion): adds default value to _resolved_domain_urn i… #9115

Merged
merged 1 commit into from Oct 30, 2023
Merged

fix(metadata-ingestion): adds default value to _resolved_domain_urn i… #9115

merged 1 commit into from Oct 30, 2023

Conversation

alexklavensnyt
Copy link
Contributor

Adds default value to _resolved_domain_urn in DataProduct entity to match the optional type annotation. An instantiation of DataProduct that doesn't include a _resolved_domain_urn value will raise a mypy error as _resolved_domain_urn is currently a required value.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 26, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 27, 2023
@anshbansal anshbansal merged commit 2c01914 into datahub-project:master Oct 30, 2023
55 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexklavensnyt @hsheth2 @anshbansal @maggiehays