Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(health): fix health check url authentication #9117

Merged
merged 4 commits into from Nov 3, 2023
Merged

fix(health): fix health check url authentication #9117

merged 4 commits into from Nov 3, 2023

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Oct 26, 2023 •
edited

Splitting debug and check endpoints to prevent information leaks.

Screenshot 2023-11-03 at 10 37 43 AM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Oct 26, 2023
@mar-pan
Copy link

mar-pan commented Oct 31, 2023

Hello do you know when it will be merged and live?

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@david-leifker david-leifker merged commit c2bc41d into datahub-project:master Nov 3, 2023
34 of 35 checks passed
@david-leifker
Copy link
Collaborator Author

Merged, known flake in the one cypress test was bypassed.

@kopax-polyconseil
Copy link
Contributor

Where is documented that endpoint please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@darnaut darnaut Awaiting requested review from darnaut

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@david-leifker @mar-pan @kopax-polyconseil @pedro93 @maggiehays