fix(siblingsHook): add logic to account for non dbt upstreams #9154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro93
reviewed
Nov 30, 2023
Updated! Thanks |
pedro93
approved these changes
Nov 30, 2023
|
Thank you for clarifying |
anshbansal
requested changes
Dec 4, 2023
anshbansal
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, when there is an upstream connection such as
kafka -> snowflake, the dbtUpstream will be zero and we'll print outlog.error("{} has an unexpected number of dbt upstreams: {}. Not adding any as siblings.", sourceUrn.toString(), dbtUpstreams.size());. This is spamming MAE logs.The desired behavior is that the above error log only prints out if there are multiple dbt upstreams, as that's unexpected.
This PR makes it so that non-dbt upstream lineage is ignored in
handleSourceDatasetEvent.Checklist