feat(subtypes): support subtypes for charts in the UI #9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Nov 8, 2023
| const externalUrl = chart?.properties?.externalUrl; | ||
| return { | ||
| name, | ||
| externalUrl, | ||
| entityTypeOverride: subTypes ? capitalizeFirstLetterOnly(subTypes.typeNames?.[0]) : '', |
There was a problem hiding this comment.
should this be || Chart?
There was a problem hiding this comment.
no. null entity type override is safe. see https://github.com/datahub-project/datahub/blob/master/datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx#L247
There was a problem hiding this comment.
getOverridePropertiesFromEntity = (dataset?: Dataset | null): GenericEntityProperties => {
// if dataset has subTypes filled out, pick the most specific subtype and return it
const subTypes = dataset?.subTypes;
const extendedProperties: DatasetProperties | undefined | null = dataset?.properties && {
...dataset?.properties,
qualifiedName: dataset?.properties?.qualifiedName || this.displayName(dataset),
};
return {
name: dataset && this.displayName(dataset),
externalUrl: dataset?.properties?.externalUrl,
entityTypeOverride: subTypes ? capitalizeFirstLetterOnly(subTypes.typeNames?.[0]) : '',
properties: extendedProperties,
};
};
jjoyce0510
reviewed
Nov 8, 2023
| @@ -222,6 +225,7 @@ export class ChartEntity implements Entity<Chart> { | |||
| type: EntityType.Chart, | |||
| icon: entity?.platform?.properties?.logoUrl || undefined, | |||
| platform: entity?.platform, | |||
| subtype: entity?.subTypes?.typeNames?.[0] || undefined, | |||
There was a problem hiding this comment.
bit weird that the "t' in this is lower cased
There was a problem hiding this comment.
this is existing code. its intentional
There was a problem hiding this comment.
jjoyce0510
reviewed
Nov 8, 2023
| @@ -76,7 +79,7 @@ export const ChartPreview = ({ | |||
| name={name || ''} | |||
| urn={urn} | |||
| description={description || ''} | |||
| type="Chart" | |||
| type={capitalizeFirstLetterOnly(subType) || 'Chart'} | |||
There was a problem hiding this comment.
does capitalizeFirstLetterOnly handle case of undefined | null/
im assuming yes
There was a problem hiding this comment.
yes 🖖
jjoyce0510
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports subtypes in UI for charts on search, entity page & lineage
Checklist