fix(lineage): magical lineage layout fix #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Nov 8, 2023
|
|
||
| const filteredNodesInCurrentLayer = nodesInCurrentLayer | ||
| .filter(({ node }) => nodesToAddInCurrentLayer.indexOf(node.urn || '') > -1) | ||
| .filter((_, idx) => positionsToAddInCurrentLayer.indexOf(idx) > -1) |
There was a problem hiding this comment.
kinda interesting..
so you are going through list of nodes.. the first time you find you'll have an index and you'll see if the index is in the list of indexes.
the second time you hit, it won't be in the list of indexes. got it..
jjoyce0510
approved these changes
Nov 8, 2023
jjoyce0510
reviewed
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes layout bug with duplicate nodes in a layer
Checklist