Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pdl): Refactoring Assertion model enums out #9191

Merged
merged 2 commits into from
Nov 8, 2023
Merged

refactor(pdl): Refactoring Assertion model enums out #9191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b58790
Splitting assertion status and result type enums out
jjoyce0510 Nov 6, 2023
2b7ef9e
Merge branch 'master' into jj--refactor-assertion-event-models
hsheth2 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 1 addition & 18 deletions metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionResult.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,7 @@ record AssertionResult {
*/
@TimeseriesField = {}
@Searchable = {}
type: enum AssertionResultType {
/**
* The Assertion has not yet been fully evaluated
*/
INIT
/**
* The Assertion Succeeded
*/
SUCCESS
/**
* The Assertion Failed
*/
FAILURE
/**
* The Assertion encountered an Error
*/
ERROR
}
type: AssertionResultType

/**
* Number of rows for evaluated batch
Expand Down
23 changes: 23 additions & 0 deletions metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionResultType.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
namespace com.linkedin.assertion

/**
* The final result of evaluating an assertion, e.g. SUCCESS, FAILURE, or ERROR.
*/
enum AssertionResultType {
/**
* The Assertion has not yet been fully evaluated
*/
INIT
/**
* The Assertion Succeeded
*/
SUCCESS
/**
* The Assertion Failed
*/
FAILURE
/**
* The Assertion encountered an Error
*/
ERROR
}
7 changes: 1 addition & 6 deletions metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionRunEvent.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,7 @@ record AssertionRunEvent {
* The status of the assertion run as per this timeseries event.
*/
@TimeseriesField = {}
status: enum AssertionRunStatus {
/**
* The Assertion Run has completed
*/
COMPLETE
}
status: AssertionRunStatus

/**
* Results of assertion, present if the status is COMPLETE
Expand Down
12 changes: 12 additions & 0 deletions metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionRunStatus.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
namespace com.linkedin.assertion


/**
* The lifecycle status of an assertion run.
*/
enum AssertionRunStatus {
/**
* The Assertion Run has completed
*/
COMPLETE
}