fix(ingest/browse): Re-emit browse path v2 aspects to avoid race condition #9227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Nov 10, 2023
|
@asikowitz why aren't there any goldens files impacted by this? |
|
Good question... |
|
Ahh I think I know: both DeepDiff with ignore_order=True and my MCPDiff will ignore duplicate MCPs, since they just look at the bucket of MCPs emitted |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super annoyed with this bug and it looks really bad. Bandaid solution, but it's pretty simple. I don't think we have to worry about storing all these in memory... can't be that many.
Checklist