Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/prd 787 #9261

Merged
merged 2 commits into from Nov 21, 2023
Merged

Fix/prd 787 #9261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6d573
fix: manage settings group should not appear when no options
gaurav2733 Nov 17, 2023
0fc1abe
fix: manage settings group should not appear when no options
gaurav2733 Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 19 additions & 18 deletions datahub-web-react/src/app/settings/SettingsPage.tsx
View file
Open in desktop
Expand Up @@ -136,24 +136,25 @@ export const SettingsPage = () => {
)}
</Menu.ItemGroup>
)}

<Menu.ItemGroup title="Manage">
{showViews && (
<Menu.Item key="views">
<FilterOutlined /> <ItemTitle>My Views</ItemTitle>
</Menu.Item>
)}
{showOwnershipTypes && (
<Menu.Item key="ownership">
<TeamOutlined /> <ItemTitle>Ownership Types</ItemTitle>
</Menu.Item>
)}
{showHomePagePosts && (
<Menu.Item key="posts">
<PushpinOutlined /> <ItemTitle>Home Page Posts</ItemTitle>
</Menu.Item>
)}
</Menu.ItemGroup>
{(showViews || showOwnershipTypes || showHomePagePosts) && (
<Menu.ItemGroup title="Manage">
{showViews && (
<Menu.Item key="views">
<FilterOutlined /> <ItemTitle>My Views</ItemTitle>
</Menu.Item>
)}
{showOwnershipTypes && (
<Menu.Item key="ownership">
<TeamOutlined /> <ItemTitle>Ownership Types</ItemTitle>
</Menu.Item>
)}
{showHomePagePosts && (
<Menu.Item key="posts">
<PushpinOutlined /> <ItemTitle>Home Page Posts</ItemTitle>
</Menu.Item>
)}
</Menu.ItemGroup>
)}

<Menu.ItemGroup title="Preferences">
<Menu.Item key="preferences">
Expand Down