Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/athena): detect decimal type correctly #9270

Merged
merged 2 commits into from Nov 20, 2023
Merged

fix(ingest/athena): detect decimal type correctly #9270

merged 2 commits into from Nov 20, 2023

Conversation

bossenti
Copy link
Contributor

This PR resolves the broken detection of decimal columns introduced in #8137.

Reported in Slack

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 19, 2023
treff7es
treff7es approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@treff7es treff7es merged commit 0187480 into datahub-project:master Nov 20, 2023
39 of 49 checks passed
@bossenti bossenti deleted the fix-athena-decimal-detection branch November 20, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bossenti @treff7es