fix(ingest/lookml): emit all views with same name and different file path #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if using file_path in view_naming_pattern config.
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Nov 21, 2023
| @@ -2149,11 +2149,11 @@ def get_internal_workunits(self) -> Iterable[MetadataWorkUnit]: # noqa: C901 | |||
| maybe_looker_view.id.view_name | |||
| ): | |||
| view_connection_mapping = view_connection_map.get( | |||
| maybe_looker_view.id.view_name | |||
There was a problem hiding this comment.
can we add a comment explaining what we expect the keys of view_connection_map to be?
hsheth2
approved these changes
Nov 24, 2023
hsheth2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if using file_path in view_naming_pattern config.
Checklist