feat(ingest): clean up DataHubRestEmitter return type #9286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
Also makes the Airflow hook support arbitrary args.
hsheth2
force-pushed
the
rest-emitter-return
branch
from
b22401d
to
516bded
Compare
asikowitz
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM but there's some test failures:
FAILED tests/unit/test_airflow.py::test_datahub_rest_hook - datahub.configuration.common.OperationalError: ('Unable to emit metadata to DataHub GMS', {'message': "HTTPConnectionPool(host='test_host', port=8080): Max retries exceeded with url: //entities?action=ingest (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f44e1180730>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))"})
FAILED tests/unit/test_airflow.py::test_datahub_rest_hook_with_timeout - TypeError: __init__() got an unexpected keyword argument 'timeout_sec'
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/hooks/datahub.py
Outdated
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/hooks/datahub.py
Outdated
Show resolved
Hide resolved
| MetadataChangeProposalWrapper, | ||
| ], | ||
| ) -> Tuple[datetime, datetime]: | ||
| start_time = datetime.now() |
There was a problem hiding this comment.
Do we want to ensure timezone utc here?
There was a problem hiding this comment.
I'm keeping this the same for backwards compat for now, but eventually we should just update everything to always use non-naive datetimes
…plugin/hooks/datahub.py Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
…plugin/hooks/datahub.py Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
…b into rest-emitter-return
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the Airflow hook support arbitrary args.
Checklist