feat(ui): Add caching to search, entity profile for better UX #9362
Conversation
| @@ -88,6 +91,7 @@ export default function BasicFilters({ | |||
| <span id={SEARCH_RESULTS_FILTERS_ID}> | |||
| <FlexSpacer> | |||
| <FlexWrapper> | |||
| {loading && !visibleFilters?.length && <BasicFiltersLoadingSection />} | |||
| @@ -188,6 +188,7 @@ export const EmbeddedListSearch = ({ | |||
| variables: { | |||
| input: searchInput, | |||
| }, | |||
| fetchPolicy: 'cache-first', | |||
There was a problem hiding this comment.
oh man what a time to be alive - these possibleTypes making search caching possible!
| @@ -32,6 +32,7 @@ export default function useGetDataForProfile<T>({ urn, entityType, useEntityQuer | |||
| refetch, | |||
| } = useEntityQuery({ | |||
| variables: { urn }, | |||
| fetchPolicy: 'cache-first', | |||
There was a problem hiding this comment.
and this won't prevent showing updates when we add tags, terms, domains, documentation etc?
There was a problem hiding this comment.
testing locally things look alright to me... but never hurts to double check
There was a problem hiding this comment.
thats right -- generally we issue a refetch on changes and that will always trigger a network call!
| @@ -62,6 +62,7 @@ export const SearchPage = () => { | |||
| searchFlags: { getSuggestions: true }, | |||
| }, | |||
| }, | |||
| fetchPolicy: 'cache-and-network', | |||
There was a problem hiding this comment.
sweet so this will show cached results first and then once the network request returns it will update that cache and show updated results?
There was a problem hiding this comment.
yes! So if you change tags, owners, etc and return to search page we will indeed get the update for the user
|
unrelated tests failing.. merging! |
Summary
Checklist