Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): Remove primary color for sort selector + add t… #9363

Merged
merged 3 commits into from Dec 1, 2023
Merged

refactor(ui): Remove primary color for sort selector + add t… #9363

merged 3 commits into from Dec 1, 2023

Conversation

jjoyce0510
Copy link
Collaborator

Design improvements:

  1. Remove primary color CTA for sorting selector
  2. Display the name "sort" for default relevance sorting
  3. Adding tooltips
  4. Adding more clarity to the names in dropdown

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 30, 2023
chriscollins3456
chriscollins3456 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice definitely like the copy and tooltip a lot

@jjoyce0510
Copy link
Collaborator Author

unrelated smoke test failing. merging !

@jjoyce0510 jjoyce0510 merged commit 4562d79 into datahub-project:master Dec 1, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjoyce0510 @chriscollins3456