Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gms/search): Adding support for DOUBLE Searchable type #9369

Merged

Conversation

siladitya2
Copy link
Contributor

@siladitya2 siladitya2 commented Dec 1, 2023

Checklist

Adding support for DOUBLE Searchable type.

We are facing one issue without it, we are unable to sort numeric field values(double) of an aspect correctly with the search API query(searchAcrossEntities) as there is no option to map the aspect’s field type with numeric:double on Elastic search index(datasetindex_).

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 1, 2023
@david-leifker
Copy link
Collaborator

LGTM! Thanks!

@david-leifker david-leifker merged commit 7fb6086 into datahub-project:master Dec 6, 2023
37 of 38 checks passed
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
…project#9369)

Co-authored-by: si-chakraborty <si.chakraborty@adevinta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants