Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): resolve issue with caplog and asyncio #9377

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix(ingest): resolve issue with caplog and asyncio #9377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50384e8
fix(ingest): resolve issue with caplog and async
hsheth2 Dec 4, 2023
48984ce
fix lint
hsheth2 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ def resolve_includes(
@dataclass
class LookerViewFile:
absolute_file_path: str
connection: Optional[str]
connection: Optional[LookerConnectionDefinition]
includes: List[str]
resolved_includes: List[ProjectInclude]
views: List[Dict]
Expand Down
9 changes: 7 additions & 2 deletions metadata-ingestion/tests/unit/api/source_helpers/test_source_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import Any, Dict, Iterable, List, Union
from unittest.mock import patch

import pytest
from freezegun import freeze_time

import datahub.metadata.schema_classes as models
Expand Down Expand Up @@ -482,7 +483,7 @@ def test_auto_browse_path_v2_dry_run(telemetry_ping_mock):


@freeze_time("2023-01-02 00:00:00")
def test_auto_empty_dataset_usage_statistics(caplog):
def test_auto_empty_dataset_usage_statistics(caplog: pytest.LogCaptureFixture) -> None:
has_urn = make_dataset_urn("my_platform", "has_aspect")
empty_urn = make_dataset_urn("my_platform", "no_aspect")
config = BaseTimeWindowConfig()
Expand All @@ -499,6 +500,7 @@ def test_auto_empty_dataset_usage_statistics(caplog):
),
).as_workunit()
]
caplog.clear()
with caplog.at_level(logging.WARNING):
new_wus = list(
auto_empty_dataset_usage_statistics(
Expand Down Expand Up @@ -530,7 +532,9 @@ def test_auto_empty_dataset_usage_statistics(caplog):


@freeze_time("2023-01-02 00:00:00")
def test_auto_empty_dataset_usage_statistics_invalid_timestamp(caplog):
def test_auto_empty_dataset_usage_statistics_invalid_timestamp(
caplog: pytest.LogCaptureFixture,
) -> None:
urn = make_dataset_urn("my_platform", "my_dataset")
config = BaseTimeWindowConfig()
wus = [
Expand All @@ -546,6 +550,7 @@ def test_auto_empty_dataset_usage_statistics_invalid_timestamp(caplog):
),
).as_workunit()
]
caplog.clear()
with caplog.at_level(logging.WARNING):
new_wus = list(
auto_empty_dataset_usage_statistics(
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/tests/unit/utilities/test_perf_timer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from datahub.utilities.perf_timer import PerfTimer

approx = partial(pytest.approx, rel=1e-2)
approx = partial(pytest.approx, rel=2e-2)


def test_perf_timer_simple():
Expand Down