Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add youtube link to townhall button on docs #9381

Merged
merged 2 commits into from Dec 6, 2023
Merged

docs: add youtube link to townhall button on docs #9381

merged 2 commits into from Dec 6, 2023

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yoonhyejin yoonhyejin marked this pull request as ready for review December 5, 2023 07:33
@yoonhyejin yoonhyejin changed the title fix: change townhall button text docs: add youtube link to townhall button on docs Dec 5, 2023
hsheth2
hsheth2 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

We probably should rethink the three button layout at some point - it looks a little overwhelming, and generally you’re supposed to have a single clear call to action on a landing page

@yoonhyejin yoonhyejin merged commit dc6f169 into master Dec 6, 2023
34 of 35 checks passed
@yoonhyejin yoonhyejin deleted the docs/townhall-video branch December 6, 2023 23:59
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@yoonhyejin @Salman-Apptware
docs: add youtube link to townhall button on docs (datahub-project#9381)
2bd28ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoonhyejin @hsheth2