fix(ingest): fix metadata for custom python packages #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves the _Aspect type to a common location to prevent it from being defined twice in the eyes of type checkers.
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Dec 7, 2023
| This package should be installed alongside the main acryl-datahub package. | ||
|
|
||
| Install the custom package locally with `pip install custom-package/my-company-datahub-models` | ||
| To enable others to use it, share the file at custom-package/my-company-datahub-models/dist/*.whl and have them install it with `pip install <wheel file>.whl` |
There was a problem hiding this comment.
The star makes me think there's multiple such files, but I think there should just be one? Or do we have multiple for multiple python versions, or something like that?
There was a problem hiding this comment.
yes there should be just one file - I'll make it a bit more clear
Comment on lines
+92
to
+96
| package_data={{ | ||
| "{python_package_name}": ["py.typed"], | ||
| "{python_package_name}.models": ["schema.avsc"], | ||
| "{python_package_name}.models.schemas": ["*.avsc"], | ||
| }}, |
There was a problem hiding this comment.
by default it only packages .py files, so this tells it to also include the raw schema files in the .whl and .tar.gz files
Salman-Apptware
pushed a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the _Aspect type to a common location to prevent it from being defined twice in the eyes of type checkers.
Checklist