feat(ui) Add standardized GQL error handling function to FE #9470
Conversation
| defaultMessage: string; | ||
| } | ||
|
|
||
| export default function handleGraphQLError({ error, permissionMessage, defaultMessage }: Props) { |
There was a problem hiding this comment.
Nice I really appreciate this.
We can probably also have defaults for permission message / default message in caseyn start to add more specific error codes if we want...
Currently we have
400 -> Malformed query
401 / 403 -> Auth
500 -> Server error
but ideally we can continue to add to this!
There was a problem hiding this comment.
yes definitely! that was my thought as well - this can just handle all of the errors we care about in a more standard way - making it easier to provide specific messages for your operations.
i'll add the 400 and 500 situations as well and also handle 401 as well as 403
There was a problem hiding this comment.
so yeah we actually do handle 401 (not logged in) in App.tsx and there we redirect you to the login page so that should be good to go - i can create a const for not logged in in the new enum i have and use that as well
| defaultMessage: 'Failed to delete Query! An unexpected error occurred', | ||
| permissionMessage: 'Unauthorized to delete Query. Please contact your DataHub administrator.', | ||
| }); |
There was a problem hiding this comment.
I vote to make the permission message generic with the option to override. Unauthorized. Please contact your Datahub admin would suffice. Would mean it wouldn't need to be set for every instance of use, but will still provide sufficient feedback to the user.
There was a problem hiding this comment.
nice I like this
...hql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/query/DeleteQueryResolver.java
Outdated
Show resolved
Hide resolved
chriscollins3456
merged commit 0c940c7
into
datahub-project:master
This PR adds a new helper function that we can use throughout our FE app to standardize our error messages and make it easier to provide more helpful messages.
Right now this handles either a permissions error message or a default error message. I implemented it only for deleting a query for now as an example of how we can use this throughout the app.
Checklist