Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): disable access management ui when no roles are linked to entity #9610

Conversation

githendrik
Copy link
Contributor

Disable access management ui when no roles are linked to entity

See https://datahubspace.slack.com/archives/CV2UXSE9L/p1704699920392329 for reference.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 11, 2024
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable! quick check to see if you'd prefer to do the check if there's any roles at all for the dataset.

also - do you think it would make more sense to hide the tab entirely if there's no roles associated with it? i could go either way

datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx Outdated Show resolved Hide resolved
@githendrik
Copy link
Contributor Author

also - do you think it would make more sense to hide the tab entirely if there's no roles associated with it? i could go either way

I don’t mind either way :) would you want a 2nd (or 3rd) opinion on this? If so, feel free to @

Otherwise I’d probably keep it as-is. Wdyt?

@githendrik
Copy link
Contributor Author

I guess since there was no veto regarding disabling the tab instead of hiding it, I'd keep it as-is? Then this behaves the same as e.g. the Validation tab

@githendrik
Copy link
Contributor Author

Unfortunately Cypress seems to have some issue currently:

URL: https://download.cypress.io/desktop/12.5.1?platform=linux&arch=x64 Error: Failed downloading the Cypress binary. Response code: 502 Response message: Bad Gateway

@githendrik
Copy link
Contributor Author

any updates? :)

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make the one comment change and then we'll be good to merge! sorry for the delay on this one

datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@chriscollins3456 chriscollins3456 merged commit a4418f1 into datahub-project:master Mar 22, 2024
36 checks passed
@githendrik githendrik deleted the feature/disable-access-mgmt-tab-when-no-roles branch March 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants