feat(): Adding supports for data incidents for datasets, dashboards, charts, data jobs, data flows #9710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
jjoyce0510
force-pushed
the
jj--incidents-oss-v1
branch
from
edb7de0
to
2cb5b64
Compare
jjoyce0510
force-pushed
the
jj--incidents-oss-v1
branch
from
a3ccceb
to
6c4d311
Compare
jjoyce0510
force-pushed
the
jj--incidents-oss-v1
branch
from
4f9992c
to
a4ad261
Compare
…, and incidents fields on entities
… required inside incidents tab
jjoyce0510
force-pushed
the
jj--incidents-oss-v1
branch
from
3861541
to
7699caa
Compare
| _entityClient = entityClient; | ||
| _graphClient = graphClient; | ||
| _timeseriesAspectService = timeseriesAspectService; | ||
| _statusCache = |
There was a problem hiding this comment.
This doesn't make sense. Why include an empty cache here?
| try { | ||
| final Filter filter = buildIncidentsEntityFilter(entityUrn, IncidentState.ACTIVE.toString()); | ||
| final SearchResult searchResult = | ||
| _entityClient.filter( |
There was a problem hiding this comment.
If caching is needed, the systemEntityClient and a slight variation of the call should provide that cache without having to maintain a separate cache.
There was a problem hiding this comment.
I see, the cache is on the higher level object including data from those other services. Disregard the comment above.
There was a problem hiding this comment.
im removing the cache. it's only really required in OSS because it's expensive to compute assertion health. but its not being used anyways so im removing as you've mentioned
david-leifker
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we are adding support for Data Incidents on Datasets, Dashboards, Charts, Data Jobs, Data Flows.
Capabilities:
Also included the docs updates for docs website, including new incidents feature guide doc, and updates to policies guides.
Screenshots
Checklist
dded/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.