Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browsev2): align browse and aggregate queries #9790

Merged
merged 3 commits into from Feb 7, 2024

Conversation

RyanHolstien
Copy link
Collaborator

@RyanHolstien RyanHolstien commented Feb 6, 2024

Fixes issue in some scenarios for exact match queries where aggregation counts did not match browse counts due to different query flows under certain configurations. Also updates structured query path with some of the custom query configuration logic to keep in alignment. NOTE: OSS users would likely not run into this unless using custom query config with simpleQuery set to false or setting exclusive to true for quoted exact match queries due to the default configurations.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien added bug Bug report platform PR-s that make changes to core parts of the platform labels Feb 6, 2024
@RyanHolstien RyanHolstien self-assigned this Feb 6, 2024
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Feb 6, 2024
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending test fixes

@RyanHolstien RyanHolstien merged commit 20b9050 into datahub-project:master Feb 7, 2024
42 checks passed
@RyanHolstien RyanHolstien deleted the fix/browseCounts branch February 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report devops PR or Issue related to DataHub backend & deployment platform PR-s that make changes to core parts of the platform product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants