Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): make docker compose project name configurable #9808

Merged
merged 4 commits into from
Feb 9, 2024
Merged

feat(cli): make docker compose project name configurable #9808

merged 4 commits into from
Feb 9, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 9, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 9, 2024
hsheth2 added a commit that referenced this pull request Feb 9, 2024
@hsheth2
feat(quickstart): remove container_name
c650258 
Because we have `--remove-orphans` in the quickstart cli, this should be
ok to use on existing quickstarts as well.

Related to #9808
@hsheth2 hsheth2 mentioned this pull request Feb 9, 2024
Merged
5 tasks
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Feb 9, 2024
@hsheth2 hsheth2 merged commit 9d79e08 into master Feb 9, 2024
20 of 21 checks passed
@hsheth2 hsheth2 deleted the quickstart-proj-name branch February 9, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @david-leifker