feat(ingest): reporting logging tweaks #9835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These take advantage of `stacklevel`, which is supported in Python 3.8+.
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Feb 14, 2024
| @@ -99,11 +102,19 @@ def report_warning(self, key: str, reason: str) -> None: | |||
| warnings.append(reason) | |||
| self.warnings[key] = warnings | |||
|
|
|||
| def warning(self, key: str, reason: str) -> None: | |||
| self.report_warning(key, reason) | |||
There was a problem hiding this comment.
Should report_warning and report_failure eventually be private methods, or do you see a case for putting a warning / failure in the report without logging it?
There was a problem hiding this comment.
Yup that's the goal - I want to get rid of direct calls to report_warning and report_failure. A bunch of sources also have helper methods that are basically copies of this warning method, and I want to get rid of those too
hsheth2
added a commit
that referenced
this pull request
Feb 14, 2024
This is a quick follow up on #9835
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These take advantage of
stacklevel, which is supported in Python 3.8+.Checklist