Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-tools version #140

Merged

Conversation

MrLarssonJr
Copy link
Contributor

Description

Attempted to follow the instructions in the Running Operator Locally section of the developer documentation. When I attempted to run make install I encountered a nil pointer dereference error. (See stack trace below.)

Looking into the stack trace I realised the error originated from the controller-gen command from the controller-tools package. Looking into said package, I realised that the latest released version is v.0.14.0. The version referenced in Makefile were v0.11.2. I tried to change the referenced version to the latest version and it solved the nil pointer dereferenced issue and I could continue following the developer documentation.


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • Makefile

Copy link
Contributor

@AdheipSingh AdheipSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MrLarssonJr

@AdheipSingh AdheipSingh merged commit 84524ca into datainfrahq:master Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants