Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List only pod specific to a nodespec while checking the crash status #89

Merged
merged 1 commit into from Feb 12, 2024

Conversation

rbankar7
Copy link
Contributor

@rbankar7 rbankar7 commented Aug 7, 2023

Description

In the checkCrashStatus we are listing all the pods in the namespace for all of the druid components which does not seems right. Since we are in the loop executing the deployment operations for a single nodeSpec we should be only listing the pods which belong to that particular NodeType


This PR has:

  • been tested on a real K8S cluster to ensure the creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@rbankar7 rbankar7 marked this pull request as ready for review August 7, 2023 04:34
@AdheipSingh
Copy link
Contributor

LGTM
cc @itamar-marom

@itamar-marom
Copy link
Collaborator

@rbankar7 can you please fix the e2e tests? looks like it failed.
I will review this PR soon.

@SatyaKuppam
Copy link
Contributor

Hey @rbankar7 are you able to fix the failing tests? If you are no longer working on this I can try to fix the failing tests in a separate PR. Thanks.

@rbankar7
Copy link
Contributor Author

rbankar7 commented Jan 11, 2024

@SatyaKuppam Sorry I was not actively working on this because of other priorities..

@AdheipSingh
Copy link
Contributor

@rbankar7 is this done ?

@rbankar7
Copy link
Contributor Author

rbankar7 commented Feb 9, 2024

@AdheipSingh This is ready for review
This was previously approved but had to make changes because of the recent refactor

Copy link
Contributor

@AdheipSingh AdheipSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdheipSingh AdheipSingh merged commit 468f8ae into datainfrahq:master Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants