Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Deployer file for both clustered and non-clustered deployment in all api servers #316

Open
abhi4578 opened this issue Sep 30, 2022 · 0 comments
Open

Single Deployer file for both clustered and non-clustered deployment in all api servers #316

abhi4578 opened this issue Sep 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@abhi4578
Copy link
Contributor

  • Currently there are two deployer files and corresponding two fatjars generated :

    1. DeployerDev.java deploys non-clustered vertx which does not need zookeeper. This is useful for
      dev env
    2. Deployer.java deploys clustered vertx which deploys clustered vertx. And needs zookeeper. This is how its deployed in production.

  • It would be best to merge these files. Because some code/logic common to both might be implemented in one file but not other (eg: Bug-fix: worker verticle configuration setting #315) and also cumbersome to maintain two files which just differs in how vertx is deployed. It can be captured through flags (in jar, in maven also mostly) and conditional logic.
@abhi4578 abhi4578 added the enhancement New feature or request label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhi4578