New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable tests when singularity hub is back #91
Comments
Singularity Hub being down shouldn't be a regular thing, but it will be down for now until further notice as we address the issue. For my repos that use shub endpoints, I either changed to Docker, or in the case that it was a specific image, just disabled for now. Not much more to do. |
I think we should keep failing. Nobody will notice a skip, but sometimes we might want to do something about it and even if not so: The "passing" of the Travis builds would likely be interpreted by us as "all good" when in fact things weren't tested at all, if we would automatically skip. |
I disagree. We propagate these failures all the way to datalad proper CI tests. This leads to all PRs always failing, which implies more human costs than skipping the two affected tests in here. I proposed #92 Once that is merged, we can change the title here to "Re-enable tests when singularity hub is back". |
Merged #92. |
You've just used the api to download the container here, and I need to ask you to discontinue this until I've announced that the server is ready. You have a very limited quota, across all GET requests per week, so it's very unwise to be interacting with the API until I've had a chance to update everyone with these limits and best practices. thanks! |
@vsoch , I just pushed out (to pypi) 0.5.0 release of this extension which skips tests querying singularity hub, so our datalad core tests (which do downstream testing of released extensions) now should stop querying it as well |
Great, thanks! |
ATM datalad-containers is all red on Travis. @vsoch took the hub offline since there was some malicious user activity. I wonder if in such cases (
requests.exceptions.ConnectionError ... Failed to establish a new connection
) we should just skip the test or keep them failing as our indicator of some disturbance in the force?The text was updated successfully, but these errors were encountered: