Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: run: Move the image from inputs to extra_inputs #60

Merged
merged 3 commits into from May 28, 2019
Merged

ENH: run: Move the image from inputs to extra_inputs #60

merged 3 commits into from May 28, 2019

Commits on May 28, 2019

  1. RF: run: Use run_command() 

    Doing so gives access to the extra_inputs argument, which isn't
exposed to the user-facing interface.  run_command() lacks the --rerun
compatibility flag of Run.__call__, but that's not an issue because
containers-run doesn't expose --rerun.
    @kyleam
    kyleam committed May 28, 2019
    Copy the full SHA
    37d6d90 View commit details
    Browse the repository at this point in the history

  2. ENH: run: Move the image from inputs to extra_inputs 

    `containers-run` builds on `run`, augmenting the input list with a
Singularity image.  This means that if a user then puts "{inputs}" in
their command, the image file is included too.  This is almost
certainly surprising to the user because the user has not explicitly
specified the image with --input and is probably not aware that
containers-run adds it.  Avoid this by using run_command's recently
added extra_inputs argument.

Re: datalad/datalad#3038
Closes datalad#38.
    @kyleam
    kyleam committed May 28, 2019
    Copy the full SHA
    e936bdb View commit details
    Browse the repository at this point in the history

  3. MNT: setup.py: Bump require DataLad version for extra_inputs 

    extra_inputs was introduced in v0.11.2, but use v0.11.5 because that
will include 514545a46 (datalad/datalad#3106) as a fix for a
datalad-save regression that broke the docker adapter.
    @kyleam
    kyleam committed May 28, 2019
    Copy the full SHA
    571c203 View commit details
    Browse the repository at this point in the history