Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pytest #117

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Switch to pytest #117

merged 6 commits into from
Aug 3, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 26, 2022

Closes #116.

Note that this PR currently cannot be tested on CI, as there is no post-pytest release of datalad. (I tested the project locally by changing the datalad requirement in the tests extra to datalad @ git+https://github.com/datalad/datalad. Currently, three tests fail, all in datalad_crawler/nodes/tests/test_annex.py, all due to issues with paths in $TMPDIR that are likely to be macOS-specific.)

@jwodder jwodder added the tests Add or improve existing tests label May 26, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #117 (ce433ad) into master (e1f15fd) will decrease coverage by 4.21%.
The diff coverage is 96.88%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   81.89%   77.68%   -4.22%     
==========================================
  Files          59       60       +1     
  Lines        4778     4710      -68     
  Branches        0      699     +699     
==========================================
- Hits         3913     3659     -254     
- Misses        865      887      +22     
- Partials        0      164     +164     
Impacted Files Coverage Δ
datalad_crawler/__init__.py 100.00% <ø> (ø)
datalad_crawler/pipelines/balsa.py 91.57% <ø> (-4.22%) ⬇️
datalad_crawler/pipelines/crcns.py 49.00% <ø> (-5.00%) ⬇️
datalad_crawler/pipelines/fcptable.py 54.90% <ø> (ø)
datalad_crawler/pipelines/openfmri.py 81.35% <ø> (-5.09%) ⬇️
datalad_crawler/pipelines/openfmri_s3.py 100.00% <ø> (ø)
datalad_crawler/pipelines/simple_with_archives.py 73.68% <ø> (-15.79%) ⬇️
datalad_crawler/tests/test_register.py 100.00% <ø> (ø)
datalad_crawler/pipelines/tests/test_crcns.py 64.00% <80.00%> (-8.00%) ⬇️
datalad_crawler/pipelines/tests/test_gh.py 60.86% <80.00%> (-2.77%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0be73...ce433ad. Read the comment docs.

@yarikoptic yarikoptic force-pushed the gh-116 branch 2 times, most recently from 85a3b4c to 30cec07 Compare August 1, 2022 18:21
@yarikoptic
Copy link
Member

hm, travis stopped reacting to my changes for some reason... I thought because of somehow breaking .travis.yml with dist: focal but seems to be not the case. will need to come back to this later :-/

@yarikoptic yarikoptic marked this pull request as ready for review August 3, 2022 18:17
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Aug 3, 2022
@yarikoptic
Copy link
Member

on this note of green Travis let's merge and release!

@yarikoptic yarikoptic merged commit 53121d7 into master Aug 3, 2022
@yarikoptic yarikoptic deleted the gh-116 branch August 3, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate testing to use pytest
2 participants