Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal surgery to get github organisations crawling working again #136

Merged
merged 3 commits into from
May 26, 2023

Conversation

yarikoptic
Copy link
Member

  • just use pygithub directly
  • use Token credential for "api.github.com" or stored in cfg hub.oauthtoken

datalad core was refactored heavily and it just makes it easier to use
pygithub directly here. To not mess with credentials - just getting
the one from config
@yarikoptic yarikoptic added the patch Increment the patch version when merged label May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 32.14% and project coverage change: -0.04 ⚠️

Comparison is base (f86b5e2) 77.60% compared to head (66e9b2f) 77.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   77.60%   77.56%   -0.04%     
==========================================
  Files          60       60              
  Lines        4701     4720      +19     
  Branches      953      956       +3     
==========================================
+ Hits         3648     3661      +13     
- Misses        889      895       +6     
  Partials      164      164              
Impacted Files Coverage Δ
datalad_crawler/pipelines/gh.py 13.26% <15.78%> (+13.26%) ⬆️
datalad_crawler/pipelines/tests/test_gh.py 56.00% <62.50%> (-4.87%) ⬇️
datalad_crawler/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label May 26, 2023
@yarikoptic
Copy link
Member Author

I have pushed codespell fixed typo directly to master in 0de99c3 since unrelated. The fix worked while updating openneuro datasets, so let's proceed

@yarikoptic yarikoptic changed the title Minimal surgery to get github orgs crawling working again Minimal surgery to get github organisations crawling working again May 26, 2023
@yarikoptic yarikoptic merged commit 857ada2 into datalad:master May 26, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant