Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: NIDMResults metadata extractor draft #41

Closed
wants to merge 6 commits into from

Conversation

mih
Copy link
Member

@mih mih commented Aug 8, 2018

Quick draft of a NIDM result metadata extractor. This is using a JSON-LD representation as input that is not very suitable for the search implementations we have.

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #41 into master will decrease coverage by 0.64%.
The diff coverage is 79.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   89.03%   88.38%   -0.65%     
==========================================
  Files          19       21       +2     
  Lines         930      999      +69     
==========================================
+ Hits          828      883      +55     
- Misses        102      116      +14
Impacted Files Coverage Δ
..._neuroimaging/extractors/tests/test_nidmresults.py 100% <100%> (ø)
datalad_neuroimaging/extractors/nidmresults.py 65% <65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e83bbf...f5b09db. Read the comment docs.

@cmaumet
Copy link
Member

cmaumet commented Aug 8, 2018

@mih
Copy link
Member Author

mih commented Aug 9, 2018

Q @cmaumet: The metadata contains absolute paths, e.g.:

        "SearchSpaceMaskMap_atLocation": "/test/data/nidmresults-examples/spm_full_example001/mask.nii",

Do they have to be like this, or could they be relative to the "root" of the result structure? In the present form it is hard to locate the file in the ZIP once extracted to an arbitrary location.

@mih
Copy link
Member Author

mih commented May 9, 2019

Replaced by psychoinformatics-de/datalad-hirni#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants