Skip to content

Commit

Permalink
Adjust/add skips/xfails for the tests which are now failing on GH act…
Browse files Browse the repository at this point in the history
…ions on NFS

Kept a skip where test could have stalled.
  • Loading branch information
yarikoptic committed May 21, 2024
1 parent 448d109 commit 217cde8
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
3 changes: 2 additions & 1 deletion datalad/support/tests/test_annexrepo.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
ok_file_has_content,
ok_file_under_git,
ok_git_config_not_empty,
on_github,
on_nfs,
on_travis,
serve_path_via_http,
Expand Down Expand Up @@ -2332,7 +2333,7 @@ def test_annexjson_protocol_incorrect(path=None, *, print_opt, caplog):
# see https://github.com/datalad/datalad/pull/5400 for troubleshooting
# for stalling with unlock=False, and then with unlock=True it took >= 300 sec
# https://github.com/datalad/datalad/pull/5433#issuecomment-784470028
@skip_if(on_travis and on_nfs) # TODO. stalls
@skip_if((on_github or on_travis) and on_nfs) # TODO. stalled on travis, fails on github
# http://git-annex.branchable.com/bugs/cannot_commit___34__annex_add__34__ed_modified_file_which_switched_its_largefile_status_to_be_committed_to_git_now/#comment-bf70dd0071de1bfdae9fd4f736fd1ec
# https://github.com/datalad/datalad/issues/1651
@known_failure_githubci_win
Expand Down
4 changes: 3 additions & 1 deletion datalad/tests/test_archives.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
eq_,
ok_file_has_content,
ok_generator,
on_github,
on_nfs,
on_travis,
on_windows,
Expand Down Expand Up @@ -102,7 +103,7 @@ def check_decompress_file(leading_directories, path=None):
eq_(f.read(), '3 load')


@pytest.mark.xfail(on_travis and on_nfs, reason="https://github.com/datalad/datalad/issues/4496")
@pytest.mark.xfail((on_travis or on_github) and on_nfs, reason="https://github.com/datalad/datalad/issues/4496")
@pytest.mark.parametrize("leading", [None, 'strip'])
def test_decompress_file(leading):
return check_decompress_file(leading)
Expand Down Expand Up @@ -194,6 +195,7 @@ def test_compress_file(ext, annex):
check_compress_file(ext, annex)


@pytest.mark.xfail(on_github and on_nfs, reason="unknown. TODO: figure out")
@with_tree(**tree_simplearchive)
def test_ExtractedArchive(path=None):
archive = op.join(path, fn_archive_obscure_ext)
Expand Down
6 changes: 6 additions & 0 deletions datalad/tests/test_tests_utils_pytest.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
ok_good_symlink,
ok_startswith,
ok_symlink,
on_github,
on_nfs,
on_windows,
patch_config,
probe_known_failure,
Expand All @@ -93,6 +95,8 @@
getpwd,
)

import pytest

#
# Test with_tempfile, especially nested invocations
#
Expand Down Expand Up @@ -168,6 +172,8 @@ def test_get_resolved_values():
with patch_config({'datalad.tests.nonetwork': '1'}):
eq_(_get_resolved_flavors(flavors), ['local'])


@pytest.mark.xfail(on_github and on_nfs, reason="unknown. TODO: figure out")
def test_with_tempfile_mkdir():
dnames = [] # just to store the name within the decorated function

Expand Down

0 comments on commit 217cde8

Please sign in to comment.