Skip to content

Commit

Permalink
Merge pull request #6802 from adswa/docs-docstrings
Browse files Browse the repository at this point in the history
DOC: fix and move docstring reference into design docs
  • Loading branch information
yarikoptic committed Jul 5, 2022
2 parents 935f4b1 + 9068882 commit 8b4f05b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 16 deletions.
19 changes: 3 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ we outline the workflow used by the developers:

(If any of the above seems like magic to you, then look up the
[Git documentation](http://git-scm.com/documentation) on the web.)
Our [Design Docs](http://docs.datalad.org/en/stable/design/index.html) provide a
growing collection of insights on the command API principles and the design of
particular subsystems in DataLad to inform standard development practice.

## Development environment

Expand Down Expand Up @@ -213,22 +216,6 @@ $ tributors update-lookup allcontrib
And then we can rely on the [GitHub action](.github/workflows/update-contributors.yml) to update contributors. The action is set to run on merges to master, meaning when the contributions are finalized. This means that we add new contributors, and we
look for new orcids as we did above.


## Documentation

### Docstrings

We use [NumPy standard] for the description of parameters docstrings. If you are using
PyCharm, set your project settings (`Tools` -> `Python integrated tools` -> `Docstring format`).

[NumPy standard]: https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt#docstring-standard

In addition, we follow the guidelines of [Restructured Text] with the additional features and treatments
provided by [Sphinx].

[Restructured Text]: http://docutils.sourceforge.net/docs/user/rst/quickstart.html
[Sphinx]: http://www.sphinx-doc.org/en/stable/

## Additional Hints

### Merge commits
Expand Down
3 changes: 3 additions & 0 deletions docs/source/design/docstrings.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ each consumption scenario.
Formatting overview and guidelines
==================================

In general, the docstring format follows the `NumPy standard <https://numpydoc.readthedocs.io/en/latest/format.html#docstring-standard>`_.
In addition, we follow the guidelines of `Restructured Text <https://docutils.sourceforge.io/docs/user/rst/quickstart.html>`_ with the additional features and treatments provided by `Sphinx <https://www.sphinx-doc.org/en/master>`_, and some custom formatting outlined below.

Version information
-------------------

Expand Down

0 comments on commit 8b4f05b

Please sign in to comment.