BF(workaround): switch to use os.getcwd if something odd detected with PWD env var #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chdir in decorator
No need to swallow it, could now be used to decorate functions which return something
Codecov Report
@@ Coverage Diff @@
## master #2914 +/- ##
==========================================
+ Coverage 90.28% 90.34% +0.05%
==========================================
Files 246 246
Lines 31902 32076 +174
==========================================
+ Hits 28804 28978 +174
Misses 3098 3098
Continue to review full report at Codecov.
|
|
all the failures are known suspects and I see no reason to torture CI by merging master. Any feedback @datalad/developers ? |
|
No objections by me. Except for a poor gut feeling about the entire beast. But this is neither about this PR nor do I have a better idea. ;-) |
kyleam
approved these changes
Oct 30, 2018
| `os.getcwd()`. | ||
|
|
||
| Initial decision to either use PWD env variable or os.getcwd() is done upon | ||
| the first call of this function. |
There was a problem hiding this comment.
The workaround is ugly, but this docstring does a nice job of explaining why it exists.
|
yeah, it is quite ugly but I also see no other way yet to handle it, and I do know that I ran into this issue (of us simply relying on wrong PWD value) while working in ipython notebook... so better this than nothing imho. merging, thanks! |
yarikoptic
added a commit
that referenced
this pull request
Nov 27, 2018
## 0.11.1 (Nov 25, 2018) -- v7-better-than-v6 Rushed out bugfix release to stay fully compatible with recent [git-annex] which introduced v7 to replace v6. ### Fixes - [install]: be able to install recursively into a dataset ([#2982]) - [save]: be able to commit/save changes whenever files potentially could have swapped their storage between git and annex ([#1651]) ([#2752]) ([#3009]) - [aggregate-metadata]: - dataset's itself is now not "aggregated" if specific paths are provided for aggregation ([#3002]). That resolves the issue of `-r` invocation aggregating all subdatasets of the specified dataset as well - also compare/verify the actual content checksum of aggregated metadata while considering subdataset metadata for re-aggregation ([#3007]) - `annex` commands are now chunked assuming 50% "safety margin" on the maximal command line length. Should resolve crashes while operating ot too many files at ones ([#3001]) - `run` sidecar config processing ([#2991]) - no double trailing period in docs ([#2984]) - correct identification of the repository with symlinks in the paths in the tests ([#2972]) - re-evaluation of dataset properties in case of dataset changes ([#2946]) - [text2git] procedure to use `ds.repo.set_gitattributes` ([#2974]) ([#2954]) - Switch to use plain `os.getcwd()` if inconsistency with env var `$PWD` is detected ([#2914]) - Make sure that credential defined in env var takes precedence ([#2960]) ([#2950]) ### Enhancements and new features - [shub://datalad/datalad:git-annex-dev](https://singularity-hub.org/containers/5663/view) provides a Debian buster Singularity image with build environment for [git-annex]. [tools/bisect-git-annex]() provides a helper for running `git bisect` on git-annex using that Singularity container ([#2995]) - Added [.zenodo.json]() for better integration with Zenodo for citation - [run-procedure] now provides names and help messages with a custom renderer for ([#2993]) - Documentation: point to [datalad-revolution] extension (prototype of the greater DataLad future) - [run] - support injecting of a detached command ([#2937]) - `annex` metadata extractor now extracts `annex.key` metadata record. Should allow now to identify uses of specific files etc ([#2952]) - Test that we can install from http://datasets.datalad.org - Proper rendering of `CommandError` (e.g. in case of "out of space" error) ([#2958]) * tag '0.11.1': Adjust the date -- 25th fell through due to __version__ fiasco BF+ENH(TST): boost hardcoded version + provide a test to guarantee consistency in the future This (expensive) approach is not needed in v6+ small tuneup to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request might help to address #2910 but in an odd ad-hoc ugly fashion. See description in patch/code
If we decide to adopt this at least as a temporary stop-gap measure, then TODOs
Testing locally with smth like