Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status does not ignore directories which have only ignored files #3235

Closed
yarikoptic opened this issue Mar 17, 2019 · 0 comments
Closed

status does not ignore directories which have only ignored files #3235

yarikoptic opened this issue Mar 17, 2019 · 0 comments
Labels
fix-implemented A fix is available, but has not been merged or released, yet.

Comments

@yarikoptic
Copy link
Member 

(git)hopa:~datalad/datalad[temp-test-devel-annex]datalad
$> git status .
On branch temp-test-devel-annex
Your branch is up to date with 'gh-yarikoptic/temp-test-devel-annex'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	support/github_.py

nothing added to commit but untracked files present (use "git add" to track)

$> datalad status .
untracked: /home/yoh/proj/datalad/datalad/datalad/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/cmdline/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/cmdline/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/crawler (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/customremotes/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/customremotes/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/distribution/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/distribution/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/downloaders/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/downloaders/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/interface/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/interface/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/metadata/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/metadata/extractors/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/metadata/extractors/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/metadata/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/plugin/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/plugin/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/revolution (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/support/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/support/github_.py (file)
untracked: /home/yoh/proj/datalad/datalad/datalad/support/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/support/third/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/tests/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/ui/__pycache__ (directory)
untracked: /home/yoh/proj/datalad/datalad/datalad/ui/tests/__pycache__ (directory)

$> ls /home/yoh/proj/datalad/datalad/datalad/__pycache__
__init__.cpython-35.pyc  api.cpython-36.pyc   cmd.cpython-36.pyc     consts.cpython-35.pyc   dochelpers.cpython-35.pyc  log.cpython-37.pyc      version.cpython-36.pyc
__init__.cpython-36.pyc  api.cpython-37.pyc   cmd.cpython-37.pyc     consts.cpython-36.pyc   dochelpers.cpython-36.pyc  utils.cpython-35.pyc    version.cpython-37.pyc
__init__.cpython-37.pyc  auto.cpython-36.pyc  config.cpython-35.pyc  consts.cpython-37.pyc   dochelpers.cpython-37.pyc  utils.cpython-36.pyc
__main__.cpython-36.pyc  auto.cpython-37.pyc  config.cpython-36.pyc  coreapi.cpython-36.pyc  log.cpython-35.pyc         utils.cpython-37.pyc
__main__.cpython-37.pyc  cmd.cpython-35.pyc   config.cpython-37.pyc  coreapi.cpython-37.pyc  log.cpython-36.pyc         version.cpython-35.pyc

I am not sure if we (datalad) care about "directories" to list them, or adhere to git semantic that a directory without a file of interest is nothing to report?
kyleam added a commit to kyleam/datalad that referenced this issue Mar 18, 2019
@kyleam
BF: gitrepo.get_content_info: Do not list empty directories
f19aaca 
When we pass --directory to ls-files, pass --no-empty-directory as
well so that we do not include directories that contain only excluded
files.

Fixes datalad#3235.
@kyleam kyleam mentioned this issue Mar 18, 2019
Merged
@kyleam kyleam added the fix-implemented A fix is available, but has not been merged or released, yet. label Mar 18, 2019
kyleam added a commit to kyleam/datalad that referenced this issue Mar 18, 2019
@kyleam
BF: gitrepo.get_content_info: Do not list empty directories
bff33d5 
When we pass --directory to ls-files, pass --no-empty-directory as
well so that we do not include directories that contain only excluded
files.

Fixes datalad#3235.
kyleam added a commit to kyleam/datalad that referenced this issue Mar 19, 2019
@kyleam
BF: gitrepo.get_content_info: Do not list empty directories
83e889e 
When we pass --directory to ls-files, pass --no-empty-directory as
well so that we do not include directories that contain only excluded
files.

Fixes datalad#3235.
@mih mih closed this as completed in #3238 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-implemented A fix is available, but has not been merged or released, yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarikoptic @kyleam