Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup or modification detection issue with shortpaths #4202

Closed
mih opened this issue Feb 26, 2020 · 1 comment
Closed

Setup or modification detection issue with shortpaths #4202

mih opened this issue Feb 26, 2020 · 1 comment
Labels
platform-windows Issue concerned with Windows severity-minor a problem which doesn't affect the package's usefulness, and is presumably trivial to fix stale-issue-closed-without-resolution

Comments

@mih
Copy link
Member

mih commented Feb 26, 2020

Replacing ok_clean_git() with assert_repo_status() reveals the following breakage on Windows systems that report short paths. it is unclear whether it has been there before and ok_clean_git didn't see it (in which case it would explain various supernatural behavior of the testrepos), or status reporting (i.e. GitRepo._diffstatus()) and friends are broken on such systems (unlikely, because this is the only test that fails).

======================================================================
FAIL: datalad.tests.test_utils_testrepos.test_BasicAnnexTestRepo
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\nose\case.py", line 198, in runTest
    self.test(*self.arg)
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\datalad\tests\utils.py", line 691, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\datalad\tests\test_utils_testrepos.py", line 51, in test_BasicAnnexTestRepo
    _test_BasicAnnexTestRepo(path)
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\datalad\tests\test_utils_testrepos.py", line 29, in _test_BasicAnnexTestRepo
    assert_repo_status(trepo.path)
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\datalad\tests\utils.py", line 1575, in assert_repo_status
    % (state, state_files, oktobefound))
AssertionError: unexpected content of state "modified": [WindowsPath('C:/Users/RUNNER~1/AppData/Local/Temp/datalad_temp_bv7pwx9p/test-annex.dat')] != []
@mih mih added platform-windows Issue concerned with Windows severity-minor a problem which doesn't affect the package's usefulness, and is presumably trivial to fix labels Feb 26, 2020
@mih mih mentioned this issue Feb 26, 2020
@mih
Copy link
Member Author

mih commented Nov 7, 2021

Thank you for reporting this issue!

However, at this point I am closing it at a time of ~600 open issues, in an attempt to regain control over the issue tracker. This particular issue was posted more than 6 months ago, has not received a single response, and does not describe an immediate software defect. Closing this issue does not imply that it is not relevant. If any reader objects the closing of this issue, please feel more than free to reopen it with an update on how it is relevant for the current state of the project, and which concrete actions to address it are ongoing or planned.

@mih mih closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-windows Issue concerned with Windows severity-minor a problem which doesn't affect the package's usefulness, and is presumably trivial to fix stale-issue-closed-without-resolution
Projects
None yet
Development

No branches or pull requests

1 participant