Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand testing on windows #4301

Merged
merged 9 commits into from
Mar 15, 2020
Merged

Expand testing on windows #4301

merged 9 commits into from
Mar 15, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 14, 2020

mih added 6 commits March 14, 2020 13:56
@mih
TST: Generally enable support and distribution tests on windows
23d5a94
@mih
TST: There is no direct mode anymore, even on windows (fixes dataladg…
334668a 
…h-4299)
@mih
TST: Avoid quotes in test filename on windows
b551091
@mih
BF: AnnexRepo.get_metadata() reports files in platform conventions
875cc31 
Fixes dataladgh-4297
@mih
TST: Prevent crucial .gitattributes from being annexed (fixes datalad…
5e81445 
…gh-4300)
@mih
TST: Disable on all of windows
3899e86 
FileNotFoundError: [Errno 2] No such file or directory:
'C:\\Users\\mih\\AppData\\Local\\Temp\\datalad_temp_tree_4sxu0sbf\\dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd000\\ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff000'

Has little to do with the purpose of the test. Likely the test path is
too long.
@codecov
Copy link

codecov bot commented Mar 14, 2020 •
edited
Loading

Codecov Report

Merging #4301 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4301      +/-   ##
==========================================
+ Coverage   88.85%   88.87%   +0.01%     
==========================================
  Files         285      285              
  Lines       37441    37443       +2     
==========================================
+ Hits        33270    33276       +6     
+ Misses       4171     4167       -4
Impacted Files Coverage Δ
datalad/support/annexrepo.py 86.04% <ø> (ø) ⬆️
datalad/support/tests/test_globbedpaths.py 100% <100%> (ø) ⬆️
datalad/distribution/tests/test_uninstall.py 100% <100%> (ø) ⬆️
datalad/distribution/tests/test_utils.py 100% <100%> (ø) ⬆️
datalad/support/tests/test_sshrun.py 97.91% <100%> (+0.13%) ⬆️
datalad/support/tests/test_locking.py 95.23% <100%> (ø) ⬆️
datalad/support/tests/test_annexrepo.py 95.27% <100%> (+0.07%) ⬆️
...lad/distribution/tests/test_create_test_dataset.py 100% <100%> (ø) ⬆️
datalad/distribution/dataset.py 94.14% <0%> (-2.1%) ⬇️
datalad/tests/utils.py 88.94% <0%> (+0.12%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0402a40...0cc2a59. Read the comment docs.

@mih mih mentioned this pull request Mar 14, 2020
Closed
@mih mih force-pushed the tst-winmore branch 2 times, most recently from 444d4e4 to 77afb42 Compare March 14, 2020 18:02
@mih mih merged commit 6efb8dd into datalad:master Mar 15, 2020
@mih mih deleted the tst-winmore branch March 15, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: datalad.support.tests.test_annexrepo.test_AnnexRepo_metadata
1 participant
@mih