Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tributors: should not submit PRs to forks #5193

Closed
yarikoptic opened this issue Dec 1, 2020 · 4 comments · Fixed by #5197
Closed

tributors: should not submit PRs to forks #5193

yarikoptic opened this issue Dec 1, 2020 · 4 comments · Fixed by #5197
Assignees

Comments

@yarikoptic
Copy link
Member

incident: jwodder#1

result of the merge of #4789 , might need workflow tune up, @vsoch - do you have a moment to tune it up to the "best con/tributors practices"?

@vsoch
Copy link
Collaborator

vsoch commented Dec 1, 2020

@yarikoptic I think that's in the settings for the repository?

@yarikoptic
Copy link
Member Author

indeed, now that all forks have a copy of that workflow it would run for them as well, and they could selectively disable it in Settings -> Actions I guess, but IMHO it is simply not a desirable default behavior: most likely we should just limit that workflow to run only when ran on master of this (not any fork) repository.

@vsoch
Copy link
Collaborator

vsoch commented Dec 2, 2020

You could then have it stop before it does anything by defining it in the workflow, e.g.,

if: contains(github.repository, "datalad/datalad")
steps:
 - run: echo "I only run if datalad/datalad is running the action"

Not tested, but some derivative of the above should work :)

@yarikoptic
Copy link
Member Author

thank you @vsoch,
Dear @jwodder , please add such conditioning

yarikoptic added a commit that referenced this issue Dec 2, 2020
Prevent update-contributors from running on forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants