Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General config overrides mechanism and -c option for the cmdline #1351

Merged
merged 5 commits into from
Mar 1, 2017

Conversation

mih
Copy link
Member

@mih mih commented Mar 1, 2017

Addresses #958

At present we have no simple way to test the few lines in main.py.

…ladgh-958)

TODO: Make GitRepo pass overrides on to Git via -c options
@mih
Copy link
Member Author

mih commented Mar 1, 2017

Buildbot failure is due to the way the tests are executed there, i.e.

python -c 'import nose; nose.main()' -s -v datalad

it considers -c as sys.argv[0] and now there is an actual -c option in datalad. Can we use the same test invocation in the buildbots that we use on travis, i.e. via a call to nosetests? @yarikoptic

@codecov-io
Copy link

codecov-io commented Mar 1, 2017

Codecov Report

Merging #1351 into master will decrease coverage by 0.07%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   89.22%   89.14%   -0.08%     
==========================================
  Files         237      237              
  Lines       24658    24678      +20     
==========================================
- Hits        22000    21999       -1     
- Misses       2658     2679      +21
Impacted Files Coverage Δ
datalad/tests/test_config.py 100% <100%> (ø) ⬆️
datalad/config.py 98.58% <100%> (+0.02%) ⬆️
datalad/cmdline/main.py 76.02% <50%> (-0.74%) ⬇️
datalad/log.py 92.17% <0%> (-5.22%) ⬇️
datalad/crawler/nodes/matches.py 83.49% <0%> (-4.86%) ⬇️
datalad/tests/utils.py 88.41% <0%> (-1.13%) ⬇️
datalad/utils.py 89.1% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2536b...d8f07e0. Read the comment docs.

@mih
Copy link
Member Author

mih commented Mar 1, 2017

These changes are now a requirement for #1350.

@yarikoptic
Copy link
Member

how come travis is happy and all buildbots aren't?

@mih
Copy link
Member Author

mih commented Mar 1, 2017

@yarikoptic the answer is in the message above. And in #1353

@mih
Copy link
Member Author

mih commented Mar 1, 2017

#1353 now merged into this one.

@mih
Copy link
Member Author

mih commented Mar 1, 2017

OK, travis and buildbots (minus the ones with general trouble) are OK. Good to merge. Count down started. Veto?

@yarikoptic yarikoptic merged commit c6e9d5a into datalad:master Mar 1, 2017
@mih
Copy link
Member Author

mih commented Mar 1, 2017

Gracie!

@mih mih deleted the nf-cfg-override branch March 2, 2017 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants