-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General config overrides mechanism and -c
option for the cmdline
#1351
Conversation
See docstring diff for details.
…ladgh-958) TODO: Make GitRepo pass overrides on to Git via -c options
Buildbot failure is due to the way the tests are executed there, i.e.
it considers |
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 89.22% 89.14% -0.08%
==========================================
Files 237 237
Lines 24658 24678 +20
==========================================
- Hits 22000 21999 -1
- Misses 2658 2679 +21
Continue to review full report at Codecov.
|
These changes are now a requirement for #1350. |
how come travis is happy and all buildbots aren't? |
@yarikoptic the answer is in the message above. And in #1353 |
Avoids complicated failure in PY3 regarding an assumption about the docs.
#1353 now merged into this one. |
OK, travis and buildbots (minus the ones with general trouble) are OK. Good to merge. Count down started. Veto? |
Gracie! |
Addresses #958
At present we have no simple way to test the few lines in
main.py
.