NF: Introduce always_commit option #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are we becoming lazy? how would I know that it works? ;) |
|
Haha - just wanted to know whether you agree on having the whole thing in always-commit-mode. May be you want to see it as an option for single commands only. |
|
yarik: we can do one step at a time ;-) but tests would be relevant in any case ;-) |
Added test for always-commit-mode.
bpoldrack
changed the title
| @@ -152,6 +156,14 @@ def _run_annex_command(self, annex_cmd, git_options=[], annex_options=[], | |||
| debug = ['--debug'] if lgr.getEffectiveLevel() <= logging.DEBUG else [] | |||
| backend = ['--backend=%s' % backend] if backend else [] | |||
|
|
|||
| if git_options is None: | |||
| git_options = [] | |||
There was a problem hiding this comment.
git_options = git_options or [] could have worked as well ;-)
| @@ -152,6 +156,12 @@ def _run_annex_command(self, annex_cmd, git_options=[], annex_options=[], | |||
| debug = ['--debug'] if lgr.getEffectiveLevel() <= logging.DEBUG else [] | |||
| backend = ['--backend=%s' % backend] if backend else [] | |||
|
|
|||
| git_options = git_options[:] if git_options else [] | |||
| annex_options = annex_options[:] if annex_options else [] | |||
There was a problem hiding this comment.
theoretically it wasn't needed here, since we didn't modify it, right? (but ok to leave in -- just trying to see if I am not missing anything)
There was a problem hiding this comment.
ah -- [:] wasn't needed what I meant... anyways -- ignore ;) better be safe than sorry
yarikoptic
added a commit
that referenced
this pull request
May 6, 2015
NF: Introduce always_commit option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed herein, always_commit works as a mode of operation. Set to false to not instantly commit changes by git-annex calls.
Note: windows fails due to issue #147