Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: skip first progress update from annex since might be "too stale" #1434

Merged
merged 5 commits into from
Mar 25, 2017

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Mar 24, 2017

hopefully with future version we could avoid it

Also

  • now it wraps update of tqdm in try/except just to avoid sporadic crash due to oh so important tqdm raising an exception ;)
  • fixed up some PY3 issues with decoding/encoding json output from annex on python3.5 (as discovered while testing nipype workshop docker image with 0.5.0 under python3). That lead to absent actual progress in the progressbars under python3
  • fixed use of re.split so it doesn't issue a warning (Closes fixup to avoid warning on python3 #1433)

Closes #1222

@codecov-io
Copy link

codecov-io commented Mar 24, 2017

Codecov Report

Merging #1434 into master will decrease coverage by 55.65%.
The diff coverage is 6.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1434       +/-   ##
===========================================
- Coverage   89.44%   33.78%   -55.66%     
===========================================
  Files         236      236               
  Lines       24851    24860        +9     
===========================================
- Hits        22227     8400    -13827     
- Misses       2624    16460    +13836
Impacted Files Coverage Δ
datalad/ui/progressbars.py 52.38% <0%> (-38.98%) ⬇️
datalad/support/annexrepo.py 57.83% <0%> (-32.87%) ⬇️
datalad/cmd.py 86.76% <100%> (-6.87%) ⬇️
datalad/crawler/pipelines/tests/test_crcns.py 0% <0%> (-100%) ⬇️
datalad/export/tests/test_tarball.py 0% <0%> (-100%) ⬇️
datalad/crawler/dbs/tests/test_files.py 0% <0%> (-100%) ⬇️
datalad/metadata/parsers/tests/test_aggregate.py 0% <0%> (-100%) ⬇️
datalad/distribution/tests/test_create.py 0% <0%> (-100%) ⬇️
datalad/cmdline/tests/test_helpers.py 0% <0%> (-100%) ⬇️
datalad/metadata/parsers/tests/test_bids.py 0% <0%> (-100%) ⬇️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec383b...216555a. Read the comment docs.

@yarikoptic yarikoptic force-pushed the bf-pbars branch 2 times, most recently from 860dc73 to 216555a Compare March 25, 2017 03:19
@yarikoptic yarikoptic merged commit 83ce9cb into datalad:master Mar 25, 2017
@yarikoptic yarikoptic deleted the bf-pbars branch April 2, 2017 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixup to avoid warning on python3 Errors due to nice hardware ;-)
2 participants