Command to execute "prepared procedures" #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both replicate and replace functionality that is currently only available as part of `create`, but is frequently needed at a latter stage in the life span of a dataset.
Codecov Report
@@ Coverage Diff @@
## master #2603 +/- ##
==========================================
- Coverage 90.32% 90.31% -0.02%
==========================================
Files 241 242 +1
Lines 30265 30375 +110
==========================================
+ Hits 27337 27432 +95
- Misses 2928 2943 +15
Continue to review full report at Codecov.
|
Example:
datalad \
-c datalad.locations.system-procedures=/bin \
-c 'datalad.clean.run-before=echo COMPLAIN' \
clean
The above prints "COMPLAIN" just before the `clean` command is executed.
Also bring back the old test.
Simply by installing them into `resources/procedures` underneath their own module.
I'll take a look at it today. |
|
OSX looks like spurious connection failure |
kyleam
added a commit
to kyleam/datalad
that referenced
this pull request
Jun 4, 2018
This feature will be used for dataset templates, and the ability to run things with a dirty dataset and to save specific outputs is useful in general. Re: datalad#2593, datalad#2603
|
Arrg, forgot that docs were pending... Coming shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational is in #2593 AKA
run-before/run_afterconfiguration snippetsThe current state of the PR implements the procedural aspects of #1462.
This will not be complete until
rungets a feature extension discussed in #2593. But already does meaningful things now (but limited to clean datasets right now).Desired functionality is not limited to dataset management/setup use cases (for which datalad could ship a bunch of procedures), but also targets totally custom user-provided functionality. Example:
A dataset can provided implementations of a bunch of algorithms. Another dataset can include this dataset as a subdataset and configure its own
datalad.locations.dataset-proceduresconfig to extend search for procedures to the subdataset directory. This can be used to expose a "toolchain" of arbitrary procedures to the new parent dataset. Such procedures can be full blow data processing pipelines...TODOs (not necessarily all in this PR):
run-before/run_afterfunctionality that is commented out right now. This will reenable the configuration handling to run arbitrary procedures before and after other commands, based on user configuration. Use case: "create --run-after mydatasetsetuproutine" -> dataset templates.runwork with dirty datasets @kyleam do you have some extra juice for that?run: Add --explicit flag #2607