Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: protocols: Don't assume GitRepo runs a callable #3145

Merged
merged 2 commits into from Feb 10, 2019

Commits on Feb 7, 2019

  1. TST: protocol: Don't use GitRepo() to test callable

    protocol.py distinguishes between external commands and callables.  To
    test the "callable" case, we create a GitRepo, assuming that this will
    lead to gitpy.Repo.init() being executed through the runner.  But in
    -revolution, RevolutionGitRepo overrides _create_empty_repo() and uses
    the external command 'git init' as of 8b9d65a (ENH: Expose git-init
    options, create without GitPython, 2018-10-29).  As a result, these
    protocol tests fail if we substitute RevolutionGitRepo for GitRepo.
    
    Use os.mkdir to prepare for the absorption of RevolutionGitRepo into
    GitRepo.
    kyleam committed Feb 7, 2019
    Copy the full SHA
    38ac60a View commit details
    Browse the repository at this point in the history
  2. TST: gitrepo: Add test for runner with non-default protocol

    The last commit dropped the GitRepo bits from test_protocols.py, which
    means we're no longer testing that things seem to get wired up
    correctly when a custom runner with a non-default protocol is passed
    to GitRunner.  Add a test to test_gitrepo.py to make up for that.
    kyleam committed Feb 7, 2019
    Copy the full SHA
    2f2fb30 View commit details
    Browse the repository at this point in the history