Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: ssh: Support specifying identity file via environment variable #3149

Merged
merged 4 commits into from Feb 15, 2019
Merged

ENH: ssh: Support specifying identity file via environment variable #3149

merged 4 commits into from Feb 15, 2019

Commits on Feb 12, 2019

  1. TST+BF: sshconnector: Fix stale socket path construction 

    This test was written at a time when the socket path basename was
simply the plain hostname.  The basename has been a hash of various
connection details since 5be560a (BF+ENH: Hash-based unique
ControlPaths for SSH (fixes dataladgh-1243), 2017-01-31).
    @kyleam
    kyleam committed Feb 12, 2019
    Copy the full SHA
    9cf3e0f View commit details
    Browse the repository at this point in the history

  2. ENH: ssh: Add identity_file parameter to get_connection_hash() 

    Upcoming commits will make it possible to configure an identity file
to pass to ssh's -i.  Consider the identity file when creating the
connection hash because it's a defining feature of the connection.
    @kyleam
    kyleam committed Feb 12, 2019
    Copy the full SHA
    e9009ec View commit details
    Browse the repository at this point in the history

  3. ENH: SSHConnection: Support custom identity files 

    The next commit will make this accessible to outside callers by
adjusting SSHManager and exposing a configuration variable.
    @kyleam
    kyleam committed Feb 12, 2019
    Copy the full SHA
    dc3226f View commit details
    Browse the repository at this point in the history

  4. ENH: ssh: Support configuring an identity file 

    This enables callers to use sshrun with non-standard identity files.
For example, in the ReproMan project, we want to use DataLad commands
with an AWS EC2 instance.  In this case, the host will not be in
.ssh/config, and the key files are usually not in the default
location.

A plain environment variable would do for the above usecase, but add
it as a variable in common_cfg.py for the visibility and
documentation.
    @kyleam
    kyleam committed Feb 12, 2019
    Copy the full SHA
    93c8651 View commit details
    Browse the repository at this point in the history