Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: do not cause a side-effect on kwargs in @eval_results #3249

Merged
merged 1 commit into from Mar 19, 2019
Merged

BF: do not cause a side-effect on kwargs in @eval_results #3249

merged 1 commit into from Mar 19, 2019

Commits on Mar 19, 2019

  1. BF: do not cause a side-effect on kwargs in @eval_results 

    Ran into it while creating a test where multiple kwargs should have been
consistently passed to subsequent invocations of metadata (as a function or
a method).  But pre-created kwargs dictionary was augmented by calling
metadata, which (as any side-effect) was quite confusing.
    @yarikoptic
    yarikoptic committed Mar 19, 2019
    Copy the full SHA
    b096783 View commit details
    Browse the repository at this point in the history