Enabled testrepo-based tests on Windows #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
reviewed
Dec 31, 2019
This changes removes the ability to deal with filenames that have trailing slashes on non-windows systems for reasons of implementation simplicity. If there are such file names we might reconsider, but I doubt that any other part of datalad can handle those. Fixes dataladgh-3974
Made possible by fix of dataladgh-3974
Codecov Report
@@ Coverage Diff @@
## master #3975 +/- ##
==========================================
- Coverage 89.78% 89.72% -0.07%
==========================================
Files 271 271
Lines 36323 36351 +28
==========================================
+ Hits 32612 32615 +3
- Misses 3711 3736 +25
Continue to review full report at Codecov.
|
Possibly temporarily. Hints in comments in diff.
mih
changed the title
The file:// URLs we generate are not compatible with git submodule on windows
A bunch of additional tests are running now. Each failure is annotated with a link the the traceback log.
mih
force-pushed
the
bf-3974
branch
3 times, most recently
from
d11eef2
to
3039518
Compare
Include a (within-file) code move in order to get failure decorators defined before first use
|
Given that this PR makes a number of additional tests run, with relatively minimal impact on behavior on other platforms I'll merge this one now. A follow-up PR will (have to) come with #3977, so potential fixups can be incorporated there. |
kyleam
added a commit
to kyleam/datalad
that referenced
this pull request
Oct 23, 2020
A good number of test modules no longer show up in the appveyor logs, including those that test very basic and important functionality (e.g., GitRepo, save, get, and clone). It looks like these were lost starting with dataladgh-3975 (2020-01-02), in particular the last commit of that series (715be1f). One change of that commit was to decorate with_testrepos() with known_failure_appveyor(). (Before the series, the function returned by with_testrepos() raised a SkipTest if on Windows.) Based on replacing the decorator with a plain SkipTest [*], it seems that any module that uses with_testrepos() isn't executed on appveyor (for reasons that I don't understand). Drop the known_failure_appveyor() decorator and instead raise a SkipTest if on appveyor to restore the execution of tests modules. Closes datalad#4411. [*] https://ci.appveyor.com/project/mih/datalad/builds/35927969
1 task
kyleam
added a commit
to kyleam/datalad
that referenced
this pull request
Oct 24, 2020
A good number of test modules no longer show up in the appveyor logs, including those that test very basic and important functionality (e.g., GitRepo, save, get, and clone). It looks like these were lost starting with dataladgh-3975 (2020-01-02), in particular the last commit of that series (715be1f). One change of that commit was to decorate with_testrepos() with known_failure_appveyor(). (Before the series, the function returned by with_testrepos() raised a SkipTest if on Windows.) Based on replacing the decorator with a plain SkipTest [*], it seems that any module that uses with_testrepos() isn't executed on appveyor (for reasons that I don't understand). Drop the known_failure_appveyor() decorator and instead raise a SkipTest if on appveyor to restore the execution of these test modules. Closes datalad#4411. [*] https://ci.appveyor.com/project/mih/datalad/builds/35927969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as much as feels feasible right now. In any case, this is a huge step forward in terms of critical test coverage on windows. We are now in the position to investigate individual tests, instead of facing global failure.
There is still an open issue with
get_local_file_ur l()#3977, but given that this is needed for #3966 it will have to come in a separate PR.