Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: gh-3997, never use the worktree as reference when diffing against a commit #3999

Merged
merged 4 commits into from Jan 9, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jan 9, 2020

Story in gh-3997

@mih mih added this to the Release 0.12.0 milestone Jan 9, 2020
@mih
Copy link
Member Author

@mih mih commented Jan 9, 2020

This must go into 0.12, hence quick feedback is appreciated.

kyleam
kyleam approved these changes Jan 9, 2020
datalad/core/local/tests/test_diff.py Outdated Show resolved Hide resolved
datalad/support/gitrepo.py Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #3999 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3999      +/-   ##
==========================================
+ Coverage   89.68%   89.69%   +<.01%     
==========================================
  Files         271      271              
  Lines       36382    36394      +12     
==========================================
+ Hits        32631    32643      +12     
  Misses       3751     3751
Impacted Files Coverage Δ
datalad/support/gitrepo.py 89.47% <ø> (ø) ⬆️
datalad/core/local/tests/test_diff.py 99.48% <100%> (+0.03%) ⬆️
datalad/log.py 82.69% <0%> (-7.22%) ⬇️
datalad/tests/test_log.py 98.03% <0%> (-0.99%) ⬇️
datalad/downloaders/tests/test_http.py 60.58% <0%> (+2.18%) ⬆️
datalad/downloaders/http.py 74.9% <0%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90caee8...7d9f19d. Read the comment docs.

kyleam added a commit that referenced this issue Jan 9, 2020
@kyleam kyleam merged commit 7d9f19d into datalad:master Jan 9, 2020
17 checks passed
@mih mih deleted the bf-3997 branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants